src/sbbs3 js_msg_area.c 1.67 1.68
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28178

Modified Files:
js_msg_area.c
Log Message:
Replace all illegal newsgroup name characters (per RFC3977) with '_' in newsgroup property.

Note that any exascii is also illegal, but I don't feel like doing the
UTF-8 conversion thing today. Also, you can manually stick in illegal characters if you like... but then it's a feature, not a bug.



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 js_msg_area.c 1.68 1.69
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22105

Modified Files:
js_msg_area.c
Log Message:
Enforce ABNF from RFC5536 for newsgroup property since it's stricter than
the one in RFC3977. Technically, you could have those groups, you just couldn't have any netnews articles in them. :-)



--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 js_msg_area.c 1.69 1.70
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1588

Modified Files:
js_msg_area.c
Log Message:
Add (finally) fido_netmail_settings and inet_netmail_settings (bit-field) properties to msg_area object. See NMAIL_* in sbbsdefs.js for the bit values.

--- SBBSecho 3.05-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 js_msg_area.c 1.70 1.71
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10806

Modified Files:
js_msg_area.c
Log Message:
Fix apparent typo in revision 1.69 by deuce


--- SBBSecho 3.05-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 js_msg_area.c 1.71 1.72
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28089

Modified Files:
js_msg_area.c
Log Message:
Add the new sub "print_mode" configuration property (P_* flags) to use when printing messages in this sub via putmsg, etc.


--- SBBSecho 3.08-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 js_msg_area.c 1.72 1.73
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30253

Modified Files:
js_msg_area.c
Log Message:
Expose the new sub n_pmode setting (bitfield) as the "print_mode_neg" property.

--- SBBSecho 3.08-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/2d421cb3bc706591c9f76508
Modified Files:
src/sbbs3/js_msg_area.c
Log Message:
Fix: can_* and is_* properties were not dynamic. Added "posts" property.The following properties would only reflect the status at the time themsg_area object was initialized:- can_access- can_read- can_post- is_operator- is_moderated... so if changes were made the user while online, for example, theseproperty values would *not* also change to reflect the current state.The grp[] and grp_list[] 'can_access' properties still have this flaw.Also: Add a new "posts" property to the sub[] and sub_list[] objects toreport the current number of posted messages (quicker than opening a MsgBaseinstance).
--- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/b6584f1e735f735feb3079fd
Modified Files:
src/sbbs3/js_msg_area.c
Log Message:
Fix NULL-ptr dereferences when subscan is NULL
--- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/a30b854100676b2c72aadfdc
Modified Files:
src/sbbs3/js_msg_area.c
Log Message:
"posts" property doesn't rely on subscan pointer.
--- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/9314c48c862d5767842cba08
Modified Files:
src/sbbs3/js_msg_area.c
Log Message:
Fix sub[] property setter - private data pointer type wrongThe private data pointer is no longer a subscan_t*. This likely explains the reported crashes when using DDMsgReader and the most recent changes (fixes) to the msg_area object.
--- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/48709dcb456c6ef94d2ada39
Modified Files:
src/sbbs3/js_msg_area.c
Log Message:
Fix: sub[] property getter needs to return TRUE always... even when there's no private data.Should fix "TypeError: sub.code is undefined"
--- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/js_msg_area.c
By: Rob Swindell to Git commit to main/sbbs/master on Mon Jan 04 2021 12:56 pm

The private data pointer is no longer a subscan_t*. This likely explains the reported crashes when using DDMsgReader and the most recent changes (fixes) to the msg_area object.

I've seen the posts on the crashes. I'm not entirely sure what the isue might be, but do you think there's anything I might need to change in my reader?

Nightfox

---
■ Synchronet ■ Digital Distortion: digitaldistortionbbs.com
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/js_msg_area.c
By: Nightfox to Rob Swindell on Mon Jan 04 2021 01:35 pm

Re: src/sbbs3/js_msg_area.c
By: Rob Swindell to Git commit to main/sbbs/master on Mon Jan 04 2021 12:56 pm

The private data pointer is no longer a subscan_t*. This likely explains the reported crashes when using DDMsgReader and the most recent changes (fixes) to the msg_area object.

I've seen the posts on the crashes. I'm not entirely sure what the isue might be, but do you think there's anything I might need to change in my reader?

No, it was just a side-effect of a different bug-fix I made on Jan-1. The side-effect bug should now be fixed too.
--
digital man

Synchronet/BBS Terminology Definition #55:
PCMS = Programmable Command and Menu Structure (introduced in SBBS v2)
Norco, CA WX: 62.8°F, 58.0% humidity, 10 mph ENE wind, 0.00 inches rain/24hrs --- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/9e85be8fe69371e310899e2f
Modified Files:
src/sbbs3/js_msg_area.c
Log Message:
Setter needs to return true even when the scan pointer is NULL(e.g. when run as
a timed event) - this bug was introduced in the "Fix sub[] property setter" crash bug fix 2 commits ago.This fixes the "TypeError: sub.code is undefined" error.
--- SBBSecho 3.12-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/2faa619e13ae9d9164f87195
Modified Files:
src/sbbs3/js_msg_area.c
Log Message:
mod_ar is not a pointer, it's an array.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/58a0af35627eadbbdb4e4159
Modified Files:
src/sbbs3/js_msg_area.c
Log Message:
Add 'fidonet_addr' property to msg_area.sub[]Fixes issue #398
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/4beab2c67bcb56ceec7142da
Modified Files:
src/sbbs3/js_msg_area.c
Log Message:
Use JS_ValueToECMAUint32() instead of JS_ValueToInt32() for scan_ptr prop set

scan_cfg and last_read props too. This gives us use of the entire 32-bit range of an unsigned int. But does someone actually have a message base with message numbers in the billions?

This is an attempt to fix isssue #792, but I suspect scan_ptr might instead be trying to be set to NaN or ... ?
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)