src/sbbs3 chksmb.c 1.58 1.59
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
chksmb.c
Log Message:
Changed 'fixsmb' suggestion to be less optomistic.


--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.59 1.60
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
chksmb.c
Log Message:
Added an option ('-i') to not report missing Message IDs (it's normal
for very old message bases).


--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.60 1.61
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
chksmb.c
Log Message:
Print all the details of a corrupted hash record.


--- SBBSecho 3.03-Win32
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.61 1.62
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27074

Modified Files:
chksmb.c
Log Message:
Resolve msvc warnings (and confirm that cvs commits are making it into
syncprog and the commit log again).


--- SBBSecho 3.03-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.62 1.63
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12858

Modified Files:
chksmb.c
Log Message:
Replace the hard-coded beep/BEL characters in the "Hit any key to continue..." prompts with the conditional beep enabled only with the '-b' option
(silent by default). Thanks to Nelgin.


--- SBBSecho 3.05-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.63 1.64
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
chksmb.c
Log Message:
Detect and report the message with the largest data (e.g. body text) size.


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.64 1.65
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv31941

Modified Files:
chksmb.c
Log Message:
Fix warnings raised by GCC v7.3.0:
warning: ΓÇÿ*ΓÇÖ in boolean context, suggest ΓÇÿ&&ΓÇÖ instead
note: ΓÇÿsprintfΓÇÖ output between 5 and 132 bytes into a destination of size 128


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.65 1.66
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
chksmb.c
Log Message:
Detect and report all messages with overlapping headers.
This has not actually been an observed problem, but I just realized while working on smb optimizations that this condition would not be reported by chksmb.


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/chksmb.c
By: rswindell to CVS commit on Sat Feb 16 2019 02:26:40

Modified Files:
chksmb.c
Log Message:
Detect and report all messages with overlapping headers.

i've been seeing something that may be similar with new files added to the system with addfiles (executed from tickit)... when i look at my files listings in the BBS, i'll see "strange" files marked as offline but their name is part of another file's description and their description is part of that other file's description... i have successfully removed those ""files"" from the listings by using the remove command within the BBS... the real files are not affected by this remove AFAICS... this is why i was asking about how to see offline files (on IRC) the other day... i have no idea where to look to try to figure out this problem...


)\/(ark

---
■ Synchronet ■ SouthEast Star Mail HUB - SESTAR
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/chksmb.c
By: Rampage to Digital Man on Sat Feb 16 2019 11:22:23

i forgot to add that i do have terminal captures of what i've seen and done to fix the problem if you need to see them... not sure if they will help but i do have some...


)\/(ark

---
■ Synchronet ■ SouthEast Star Mail HUB - SESTAR
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/chksmb.c
By: Rampage to Digital Man on Sat Feb 16 2019 11:22 am

Re: src/sbbs3/chksmb.c
By: rswindell to CVS commit on Sat Feb 16 2019 02:26:40

Modified Files:
chksmb.c
Log Message:
Detect and report all messages with overlapping headers.

i've been seeing something that may be similar with new files added to the system with addfiles (executed from tickit)... when i look at my files listings in the BBS, i'll see "strange" files marked as offline but their name is part of another file's description and their description is part of that other file's description... i have successfully removed those ""files"" from the listings by using the remove command within the BBS... the real files are not affected by this remove AFAICS... this is why i was asking about how to see offline files (on IRC) the other day... i have no idea where to look to try to figure out this problem...

Whatever the issue, it's not related to SMB as the current filebase doesn't use SMB. If you figure out how to reproduce the problem or send me the data files (data/dirs/*) for the corrupt areas, I'll have a look-see.

digital man

This Is Spinal Tap quote #1:
Nigel Tufnel: These go to eleven.
Norco, CA WX: 56.2°F, 51.0% humidity, 4 mph N wind, 0.12 inches rain/24hrs
--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.66 1.67
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
chksmb.c
Log Message:
If message's index offset exactly matches another message, that's already reported as "Duplicate index offset", so overlapping headers means the
index offset must not be an exact duplicate, so we don't report the same corrupt message parameter (its offset into the header file) 2 different
ways.


--- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: src/sbbs3/chksmb.c
By: Digital Man to Rampage on Sat Feb 16 2019 16:19:19

Whatever the issue, it's not related to SMB as the current
filebase doesn't use SMB.

yeah, i know it doesn't use SMB :) it was just the similarity of parts overlapping that drew my attention...

If you figure out how to reproduce the problem or send me the
data files (data/dirs/*) for the corrupt areas, I'll have a
look-see.

i hadn't thought about saving the data files before cleaning them up... i'll keep an eye out and grab them the next time i see the problem and get them to you...


)\/(ark

---
■ Synchronet ■ SouthEast Star Mail HUB - SESTAR
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

On 2019 Feb 16 16:19:18, you wrote to Rampage:

but their name is part of another file's description and their
description is part of that other file's description... i have
successfully removed those ""files"" from the listings by using the
remove command within the BBS... the real files are not affected by
this remove AFAICS... this is why i was asking about how to see offline
files (on IRC) the other day... i have no idea where to look to try to
figure out this problem...

Whatever the issue, it's not related to SMB as the current filebase doesn't use SMB. If you figure out how to reproduce the problem or
send me the data files (data/dirs/*) for the corrupt areas, I'll have
a look-see.

i don't know if you saw it or not but i did send you an email sunday evening with two of my files bases' database files zipped and two screenshots of the problem... one shot for each area...

FWIW: the only things touching tho filebases are addfiles (via tickit) and sbbs... nothing 3rd party or self-written...

)\/(ark

Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
... When man builds better mousetraps, nature builds better mice.
---
* Origin: (1:3634/12.73)

Re: src/sbbs3/chksmb.c
By: mark lewis to Digital Man on Mon Feb 18 2019 12:53 pm

On 2019 Feb 16 16:19:18, you wrote to Rampage:

but their name is part of another file's description and their
description is part of that other file's description... i have
successfully removed those ""files"" from the listings by using the
remove command within the BBS... the real files are not affected by
this remove AFAICS... this is why i was asking about how to see offline
files (on IRC) the other day... i have no idea where to look to try to
figure out this problem...

Whatever the issue, it's not related to SMB as the current filebase doesn't use SMB. If you figure out how to reproduce the problem or
send me the data files (data/dirs/*) for the corrupt areas, I'll have
a look-see.

i don't know if you saw it or not but i did send you an email sunday evening with two of my files bases' database files zipped and two screenshots of the problem... one shot for each area...

FWIW: the only things touching tho filebases are addfiles (via tickit) and sbbs... nothing 3rd party or self-written...

I saw and saved the email. I haven't looked at it yet. Most likely it's an addfiles bug. Do you have the input file to addfiles and the command-line that may have caused the corruption?

digital man

Synchronet/BBS Terminology Definition #32:
FTSC = FidoNet Technical Standards Committee
Norco, CA WX: 55.0°F, 35.0% humidity, 5 mph SSW wind, 0.00 inches rain/24hrs --- SBBSecho 3.06-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

On 2019 Feb 18 14:11:14, you wrote to me:

FWIW: the only things touching tho filebases are addfiles (via tickit)
and sbbs... nothing 3rd party or self-written...

I saw and saved the email. I haven't looked at it yet. Most likely
it's an addfiles bug.

ok...

Do you have the input file to addfiles and the command-line that may
have caused the corruption?

i can dig out the command line from my logs but tickit deletes the files.bbs file it creates when it is finished... it actually writes a new one for each file being imported...

it is actually a pretty generic command... only the area ID (and uploader name in my case) changes each time while the rest of the line stays the same... here's one of the 5 or 6 executed today...

Feb 18 16:22:07 sestar sbbs: evnt TICKIT Executing: '/sbbs/exec/addfiles fdist-xofchubs -x "XOFCHUBSLST File Dist" -zd +/sbbs/temp/event/tickit-files.bbs 24 13

/sbbs/data/addfiles.log 2>&1'.

none of the areas processed today show any corruption at this time...

)\/(ark

Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
... My hobbies include closing the elevator door before someone else gets on. ---
* Origin: (1:3634/12.73)

src/sbbs3 chksmb.c 1.69 1.70
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
chksmb.c
Log Message:
Fix the bug introduced into this copy/pasted version of ultoac
(unsigned-long to ASCII with commas) in rev 1.68 (addressing warnings).
A size_t (i) can't go negative. Duh.


--- SBBSecho 3.10-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.70 1.71
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv11786

Modified Files:
chksmb.c
Log Message:
Only warn about an invalid hash record timestamp if the time is more than an hour in the future. This allows for small adjustments in the local system clock.

--- SBBSecho 3.10-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

src/sbbs3 chksmb.c 1.71 1.72
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
chksmb.c
Log Message:
Increase the "invalid length" of a hashed data record from 1MB to 1GB. Apparently some USENET articles are >= 1MB these days. Thanks Coz.


--- SBBSecho 3.10-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/sbbs/sbbs/-/commit/17b7aee1b051c3b366c5dfa6
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Use smb_msg_type() to double-check the header type against attribute flags.The inferred message type should match the stored message type. Confirm that.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/35f764eef674aaeb7ce528b2
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Always report the total LZH compressed messagesThis looks like a 20-year-old copy/paste bug. CID 33168.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/faa31747a860b290922393c3
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Zero-initialize smb before usingAddresses CID 350318
--- SBBSecho 3.15-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/3ccd8ef8b20ce61a37fe4d5a
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Fix copy/paste bug discovered/reported by gcc version 11.2.0... in debug print statement (MD5 hast decoded/printed as SHA-1 hash).Reported by Nelgin running gcc version 11.2.0 (Ubuntu 11.2.0-19ubuntu1)
--- SBBSecho 3.15-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/2f4bebb1d0e9e28977285cca
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Support new -S option to not check Subject CRCsthe Subject CRC calculation was changed in May of 2022 (trailing whitespace isremoved prior to calculation), so
messages imported before this date/revisionof sbbs might be detected as having an invalid/mismatch Subject CRC. This -Soption can be used to suppress such errors (for Keyop).Don't support /option syntax any longer in non-*nix builds (just -options).Options are now case-sensitive (i.e. -S and -s are different options).Bump version to 3.20.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/d9a5999debfdc1039d39626e
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Add -N option to disable to/from name CRC checkingRecently started truncating trailing whitespace from sender/recipient namesbefore calculating the CRC value
(similar to what we do for message subjectsas of a year ago). To suppress errors when evaluating messages (with trailingwhitespace in sender or recipient
namems) created or imported before thischange, use this new -N option.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/86825b66e08061e8675591ab
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Only truncate ".anything" from supplied msgbase path if it's ".shd"Make behavior consistent with smbutil and fixmsb.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/c9c90ef7186e7ecd1103bc1b
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Replace many references to "Message" with "File" when scanning a file base

This could use more cleanup (e.g. instances of "MSGERR:") and in the summary report there are still mentions of "message" after scanning a file base.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/0fd380f86a5eaa05467f08ea
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Don't check header fields of deleted messages for control characters

... related to issue #786.

Also, don't check for a message-ID if the message-type does not match the expected message type ("type mismatch").
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/5f0fb1c7455a7345da04cf6d
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Perform filename checks (index versus header fields) on filebases

I was able to corrupt a filebase using fileman.js, renaming a file
(the filename in the index as viewed with 'smbutil x' did not match
the filename listed with 'smbutil l') - yet, chksmb reported no errors
with the filebase.

Now chksmb will detect that type of corruption.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/1be9ed2323ffe0eb9e7c18b9
Modified Files:
src/sbbs3/chksmb.c
Log Message:
Update chksmb usage (msg/file bases have .shd files, not .SHD)

And try to make it clear that multiple bases can be passed on the command-line. --- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)