1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • exec/avatar_chooser.js

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Jun 25 11:47:01 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/9f47c18faebfef9da8160721
    Modified Files:
    exec/avatar_chooser.js
    Log Message:
    Avoid base64-decoding an empty user_avatar.data

    Fixes issue #413, at least the non-mouse related part. I was only
    able to reproduce it by trying to use the "Edit your avatar" menu item
    after choose "I don't want an avatar".

    This "I don't want" menu item is weird however and reappears when
    the user exits and reruns the chooser, so there's probably still
    some improvements needed with this menu item.

    The "Upload an avatar" menu item issue is likely totally unrelated.
    Please don't combine unrelated issues in the same bug report.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Jun 25 18:13:35 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/884aa6fb6368bb532e62a180
    Modified Files:
    exec/avatar_chooser.js
    Log Message:
    Address conflict with Synchronet internal mouse support

    1. Don't enable mouse support if the user's terminal is configured to not
    support it.

    2. After calling bbs.receive_file() which displays a menu and uses sbbs's
    internal mouse support, which enables a different mouse reporting mode,
    disable the console.mouse_mode (sbbs's internal mouse support) before
    re-enabling the mouse support for the avatar_chooser's own custom mouse
    mode. Fix fixes issue #414 reported by Nelgin.

    3. Fixed a typo in a message displayed to user if avatar upload failed.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net